[NU-1928] Fix special case for spel toMap extension #7329
+58
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case m: JMap[_, _] => m.keySet().containsAll(keyAndValueNames) | ||
| case _ => false | ||
| case m: JMap[_, _] => m.keySet().containsAll(keyAndValueNames) | ||
| case _: java.util.Map.Entry[_, _] => true |
There was a problem hiding this comment.
java.util.Map.Entry -> JMap.Entry?
| val map = new JHashMap[Any, Any]() | ||
| c.forEach { | ||
| case e: JMap[_, _] => map.put(e.get(keyName), e.get(valueName)) | ||
| case e: java.util.Map.Entry[_, _] => map.put(e.getKey, e.getValue) |
There was a problem hiding this comment.
What if e is not matched?
| @@ -1663,6 +1663,42 @@ class SpelExpressionSpec extends AnyFunSuite with Matchers with ValidatedValuesD | |||
| } | |||
| } | |||
|
|
|||
| test("should convert list of map entries into map") { | |||
| // this is a special case | |||
There was a problem hiding this comment.
I would remove these comments because it's says only that we didn't handle sth in the past and now test proves that we handle this situation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merge